Protocol 12.72 update #3797
Merged
Protocol 12.72 update #3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also updated looktype command with new invalid ids and max range
big thanks to @giuinktse7 for items.otb and @MillhioreBT for items.xml
It is not present in the client anymore
Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
- sendCreatureType - sendCreatureHelpers - buildInventoryList Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
nekiro
previously approved these changes
Nov 20, 2021
omarcopires
reviewed
Nov 25, 2021
|
|
||
| // String client version | ||
| if (version >= 1240) { |
There was a problem hiding this comment.
as minor versions are not supported, do we still need this check?
DSpeichert
requested changes
Nov 27, 2021
|
Linked #3771 |
Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
and added missing ITEM_GROUP_PODIUM
- added podium code placeholder - added isContainer for loot icon and quiver ammo count
- added sendResourceBalance - added sendStoreBalance - changed getClientIcons from 16 to 32 Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
and fixed hidden health creatures display Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
EPuncker
force-pushed
the
don't-mind-me,-just-a-branch-name
branch
from
7b384db
to
85dc488
Compare
DSpeichert
approved these changes
Nov 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
cid)@adminas your email btw or if you're running otclient, still use your account name)Credits
99% of the code on this PR is made by @Zbizu !!!
Special thanks to:
Issues addressed: