Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show OTB version on loading #3808

Merged
merged 1 commit into from
Nov 28, 2021
Merged

Show OTB version on loading #3808

merged 1 commit into from
Nov 28, 2021

Conversation

EPuncker
Copy link
Contributor

Co-Authored-By: Zbizu Zbizu@users.noreply.github.com

Pull Request Prelude

Changes Proposed

Just for user information

Issues addressed:

@EPuncker @Zbizu
Show OTB version on loading
5247d02 
Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
Zbizu
Zbizu approved these changes Nov 28, 2021
View reviewed changes
Copy link
Contributor

@Zbizu Zbizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally haven't ran into any issues when using it, though I haven't tested it in scenarios when otb fails to load.
I got that idea when running many different otbs (otx 12, canary 12 and tfs 12) to test various maps.

@DSpeichert DSpeichert merged commit 42a0731 into otland:master Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSpeichert DSpeichert DSpeichert approved these changes

@mattyx14 mattyx14 mattyx14 approved these changes

@Zbizu Zbizu Zbizu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EPuncker @DSpeichert @mattyx14 @Zbizu