Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golden Outfit features #3820

Merged
merged 16 commits into from
Dec 21, 2021
Merged

Golden Outfit features #3820

merged 16 commits into from
Dec 21, 2021

Conversation

omarcopires
Copy link
Contributor

Pull Request Prelude

Changes Proposed

Adding the possibility to purchase the golden outfit, display and memorial

Issues addressed:
#3758

@omarcopires omarcopires marked this pull request as ready for review November 30, 2021 16:29
@EPuncker EPuncker requested a review from a team December 1, 2021 06:06
@MillhioreBT
Copy link
Contributor

Please use the lua-style of TFS!

This just looks ugly:
examples...
image
image

the db.storeQuery function only returns two types of values: a number or false
image
Any value other than nil and false is true

omarcopires and others added 5 commits December 1, 2021 10:59
@omarcopires
Changing selfSay to npcHandler:say
571c7ed
@omarcopires
Code fixes
7209d76 
Thanks to @EPuncker for running the tests and applying the corrections
@omarcopires
Requested changes
da0b158
@omarcopires
Query correction
f1500d5
@omarcopires @nekiro @EPuncker
Adding missing list
0f8fcca 
Thanks to @EPuncker and @nekiro for all the help provided, without them it wouldn't be possible to make all the necessary changes

Co-Authored-By: nekiro <nekiro.dev@gmail.com>
Co-Authored-By: Evil Puncker <EPuncker@users.noreply.github.com>
@omarcopires omarcopires changed the title [12.15] Golden Outfit and its features [12.15] Golden Outfit Quest Dec 1, 2021
@MillhioreBT
Copy link
Contributor

perfect, thanks
image

@omarcopires omarcopires changed the title [12.15] Golden Outfit Quest Feat Golden Outfit Dec 21, 2021
@omarcopires omarcopires changed the title Feat Golden Outfit Golden Outfit features Dec 21, 2021
@EPuncker EPuncker merged commit 7b43cd4 into otland:master Dec 21, 2021
@omarcopires omarcopires deleted the golden-outfit branch December 21, 2021 22:06
marmichalski
marmichalski reviewed Dec 22, 2021
View reviewed changes
data/npc/scripts/promotion.lua
npcHandler.topic[cid] = 2
end
elseif msgcontains(msg, "armor") and npcHandler.topic[cid] == 2 then
npcHandler:say("So you wold like to donate 500.000.000 gold pieces which in return will entitle you to wear a unique armor?", cid)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wold -> would

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marmichalski marmichalski marmichalski left review comments

@EPuncker EPuncker EPuncker approved these changes

@nekiro nekiro nekiro approved these changes

@DSpeichert DSpeichert Awaiting requested review from DSpeichert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@omarcopires @MillhioreBT @EPuncker @nekiro @marmichalski