EventCallback Lib a more modern and easy way to configure #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some small but worth mentioning improvements on line 113, previously 142, checking a boolean is faster than iterating a table to check if a value exists or not
|
I plan to change something soon, so the opinions can wait please, if you have suggestion, here I am |
EPuncker
previously approved these changes
Dec 7, 2021
3 tasks
So is it ready or do you still intend to modify it? |
|
I will remove the byte support, and I will be done, today before I go to sleep I will |
EPuncker
previously approved these changes
Dec 15, 2021
|
Could you post some updated code samples? Merge in blocked due to file conflict. |
EPuncker
previously approved these changes
Dec 20, 2021
he same, I have simply modified the library to make it more readable, and in theory a little more efficient |
EPuncker
previously approved these changes
Jan 4, 2022
DSpeichert
previously approved these changes
Feb 6, 2022
EvilHero90
previously approved these changes
Feb 15, 2022
|
there is a conflict, needs rebase |
EPuncker
dismissed stale reviews from EvilHero90, DSpeichert, and themself
via
c117f7c
This reverts commit 8a31bbe.
EPuncker
approved these changes
Feb 18, 2022
nekiro
reviewed
Feb 18, 2022
Codinablack
pushed a commit
to Codinablack/forgottenserver
that referenced
this pull request
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
I changed the metatable a bit, now we can access it in a more beautiful way.
These changes allow a special configuration for network events, more information about this special in PR #3838
Issues addressed: Nothing!