Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ProtocolGame::sendModalWindow #3854

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Fix ProtocolGame::sendModalWindow #3854

merged 1 commit into from
Dec 21, 2021

Conversation

EPuncker
Copy link
Contributor

Pull Request Prelude

Changes Proposed

Fix sendModalWindow for QT clients because they have swapped default button bytes

How to reproduce:

  1. go to a bed at any house and use it
  2. modal window will open
  3. press "enter" at your keyboard

expected: execution of the selected menu option

what happen instead: action canceled, window closed

and if you do the steps above and press "esc" instead, it will execute the action...

QT clients have swapped default button bytes
@DSpeichert DSpeichert merged commit a2091aa into master Dec 21, 2021
@DSpeichert DSpeichert deleted the EPuncker-patch-4 branch December 21, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants