bugfix and optimizations: kill tracking #3861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Znote
force-pushed
the
znote-killtracking
branch
from
398fd38
to
7b614ed
Compare
Bugfix: * returns `false` if it fails to set `monsterType` (instead of returning nil when it finds it) * `monster:getType()` instead of `monster.getType()` Optimizations: * 1 function instead of 2 * Invokes `getType()` 1 time instead of 2 times. * Invokes `getOutfit()` 1 time instead of 6 times. * instantiate monsterType as a local * no need to confirm that networkMessage is set in conditional statements, since it is created locally * no need for `elseif`, or a conditional statement to determine need to send message to self, since it has already returned something otherwise.
Znote
force-pushed
the
znote-killtracking
branch
from
7b614ed
to
d3cf1c3
Compare
omarcopires
reviewed
Dec 18, 2021
|
|
||
| local monsterOutfit = monsterType:getOutfit() | ||
|
|
||
| local networkMessage = NetworkMessage() |
There was a problem hiding this comment.
we could just use msg, as is done in sources
There was a problem hiding this comment.
Yeah, but msg is ambiguous and could just mean a regular string/text.
Since this is a NetworkMessage with its metamethods, why not call it so? This makes it easier to understand what is going on for players who use this code as reference material to learn how to use NetworkMessage.
EPuncker
approved these changes
Dec 18, 2021
DSpeichert
approved these changes
Dec 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #3860
Bugfix:
falseif it fails to setmonsterType(instead of returning nil when it finds it)Player.updateKillTrackernow returns status of operation as a bool, instead of voidmonster:getType()instead ofmonster.getType()Optimizations:
getType()1 time instead of 2 times.getOutfit()1 time instead of 6 times.elseif, or a conditional statement to determine need to send message to self, since it has already returned something otherwise.Pull Request Prelude
Changes Proposed
Issues addressed: