Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fully moved item desc to Lua #3869

Merged
merged 16 commits into from
Mar 12, 2022
Merged

fully moved item desc to Lua #3869

merged 16 commits into from
Mar 12, 2022

Conversation

EPuncker
Copy link
Contributor

Pull Request Prelude

Changes Proposed

Issues addressed:

EPuncker and others added 2 commits December 20, 2021 20:24
@EPuncker @Zbizu
fully moved item desc to Lua
16ea1e3 
Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
@EPuncker @Zbizu
Update compat.lua
4f4cb7b 
Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
@EPuncker EPuncker marked this pull request as draft December 20, 2021 23:57
@EPuncker

This comment was marked as resolved.

Sign in to view
@EPuncker EPuncker marked this pull request as ready for review February 19, 2022 01:16
@EPuncker
Copy link
Contributor Author

OK I've tested most, if not all features in game, related to this and everything seems to be working except by:

  • podium feature is not displaying mount name at all, only outfit name
  • missing description to new item bonuses that @nekiro added here

@DSpeichert DSpeichert merged commit 14d6020 into otland:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Znote Znote Znote left review comments

@Zbizu Zbizu Zbizu left review comments

@DSpeichert DSpeichert DSpeichert approved these changes

@nekiro nekiro Awaiting requested review from nekiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EPuncker @DSpeichert @Znote @Zbizu