Add summon max count in MonsterType:addSummon #3883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmichalski
commented
Jan 4, 2022
| MonsterType* monsterType = getUserdata<MonsterType>(L, 1); | ||
| if (monsterType) { | ||
| summonBlock_t summon; | ||
| summon.name = getString(L, 2); | ||
| summon.speed = getNumber<int32_t>(L, 3); | ||
| summon.chance = getNumber<int32_t>(L, 4); | ||
| summon.max = getNumber<int32_t>(L, 5, -1); |
There was a problem hiding this comment.
10/10 would underflow again
soul4soul
approved these changes
Jan 5, 2022
|
works 馃憤 |
EPuncker
approved these changes
Jan 5, 2022
Znote
pushed a commit
to Znote/forgottenserver
that referenced
this pull request
Jan 30, 2022
DSpeichert
pushed a commit
that referenced
this pull request
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
@emil92b test pls 馃槑
I'm actually uncertain if there is 0 by default or some garbage value. Looking at the summoning logic probably the latter. 馃挬Changes Proposed
Add configurable max summon count in MonsterType:addSummon.
Issues addressed: Closes #3882