Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Player.addAllMounts and Player.addAllAddons #3893

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

EPuncker
Copy link
Contributor

@EPuncker EPuncker commented Jan 12, 2022

Functions by @Xikini

Pull Request Prelude

Changes Proposed

  • added Player.addAllMounts and Player.addAllAddons
  • added doPlayerAddAddons to compat.lua as it was a very used function to addon npcs (source)

@EPuncker
Copy link
Contributor Author

actually tested and working

omarcopires
omarcopires previously approved these changes Jan 12, 2022
@omarcopires
Copy link
Contributor

There could also be added functionality for this, perhaps an admin talkaction to add to the player.

@@ -358,3 +358,19 @@ end
function Player.getTotalMoney(self)
return self:getMoney() + self:getBankBalance()
end

function Player.addAllAddons(self, addon)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds quite confusing when you're adding "all addons" but... need to provide addon as argument, no?

Maybe addAddonToAllOutfits is what it actually does?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it add addon set 1 or 2, too all outfits

@DSpeichert DSpeichert merged commit d4a0aee into otland:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants