Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed double declared variable at bank NPC #3897

Merged
merged 1 commit into from
Jan 16, 2022
Merged

Fixed double declared variable at bank NPC #3897

merged 1 commit into from
Jan 16, 2022

Conversation

Diego-OT
Copy link
Contributor

Pull Request Prelude

Changes Proposed

Issues addressed:

@EPuncker EPuncker requested a review from Znote January 14, 2022 16:00
Znote
Znote approved these changes Jan 16, 2022
View reviewed changes
Copy link
Member

@Znote Znote left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For other observers wondering whats the deal here, count[cid] has already been declared earlier in the scope at line 67.
@Diego-OT, when submitting a PR, please explain why you perform a modification.

@EPuncker EPuncker changed the title Update bank.lua Fixed double declared variable at bank.lua Jan 16, 2022
@EPuncker EPuncker changed the title Fixed double declared variable at bank.lua Fixed double declared variable at bank NPC Jan 16, 2022
@EPuncker EPuncker merged commit 5df0c3f into otland:master Jan 16, 2022
Znote pushed a commit to Znote/forgottenserver that referenced this pull request Jan 30, 2022
@Diego-OT @Znote
Fixed double declared variable at bank NPC (otland#3897)
2c29702
DSpeichert pushed a commit that referenced this pull request May 9, 2022
@Diego-OT @DSpeichert
Fixed double declared variable at bank NPC (#3897)
dae5646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Znote Znote Znote approved these changes

@EPuncker EPuncker EPuncker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Diego-OT @Znote @EPuncker