Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to customize Appearance Effect for Game.createMonster, Game.createNpc & Player.setGhostMode #3914

Merged
merged 1 commit into from Feb 8, 2022

Conversation

dbjorkholm
Copy link
Member

@dbjorkholm dbjorkholm commented Jan 28, 2022

Pull Request Prelude

Changes Proposed

Issues addressed: #3905

  • Removed an unnecessary effect for summon creation as well.

src/luascript.cpp Outdated Show resolved Hide resolved
@nekiro
Copy link
Member

nekiro commented Jan 28, 2022

isLogin was only used for sending teleport effect? lol

EPuncker
EPuncker previously approved these changes Jan 28, 2022
@dbjorkholm
Copy link
Member Author

@nekiro

isLogin was only used for sending teleport effect? lol

Funny enough, yeah. It's possible it were used for something else in the past but not these days.

src/luascript.cpp Show resolved Hide resolved
@EPuncker EPuncker merged commit 76d4aa5 into otland:master Feb 8, 2022
Codinablack pushed a commit to Codinablack/forgottenserver that referenced this pull request Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants