Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to MoveItem & OnItemMoved events #3916

Merged
merged 3 commits into from
Jan 30, 2022
Merged

Fixes to MoveItem & OnItemMoved events #3916

merged 3 commits into from
Jan 30, 2022

Conversation

Erza
Copy link
Contributor

@Erza Erza commented Jan 29, 2022

Pull Request Prelude

Changes Proposed

  1. Fix stackable items being passed with UID 0 to the Player:onItemMoved event
  2. Fix cancel messages sent to the player inside of the Player:onMoveItem event being overwritten by the engine

Issues addressed:

@EPuncker EPuncker requested a review from a team January 29, 2022 06:20
@nekiro nekiro merged commit 959c0bb into otland:master Jan 30, 2022
@Erza Erza mentioned this pull request Jan 31, 2022
Merged
3 tasks
Znote pushed a commit to Znote/forgottenserver that referenced this pull request Feb 23, 2022
@Erza @Znote
Fixes to MoveItem & OnItemMoved events (otland#3916)
83d9121
DSpeichert pushed a commit that referenced this pull request May 9, 2022
@Erza @DSpeichert
Fixes to MoveItem & OnItemMoved events (#3916)
a3655d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekiro nekiro nekiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Erza @nekiro