Merge ioguild into guild #3949
Merged
Merge ioguild into guild #3949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSpeichert
previously approved these changes
Feb 16, 2022
EPuncker
reviewed
Feb 17, 2022
EPuncker
approved these changes
Feb 17, 2022
Znote
pushed a commit
to Znote/forgottenserver
that referenced
this pull request
Feb 23, 2022
DSpeichert
pushed a commit
that referenced
this pull request
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Issues addressed:
I don't see much value in isolating these methods, they don't avoid includes and could very well be grouped together with the rest of guild stuff. Cleans up a bit of code too.