Replace LuaVariant with std::variant #3981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranisalt
commented
Feb 28, 2022
ranisalt
commented
Feb 28, 2022
ranisalt
force-pushed
the
luavariant-std-variant
branch
from
d5fcf67
to
97efb56
Compare
|
I agree with using std::variant, but I'd love for it to be wrapped in a structure with the following methods: |
ranisalt
force-pushed
the
luavariant-std-variant
branch
from
27d6377
to
925e00c
Compare
|
I saw an inconsistency, some names as |
A rewrite of the code to fix this inconsistent naming is long overdue, but should be a separate PR. |
|
I think you just have to add a TAB to the content of the class {...} and it will be ready |
MillhioreBT
requested changes
Mar 4, 2022
is this right? |
No, it should be #1481 Agh, off by one errors... |
EPuncker
added
the
enhancement
EPuncker
approved these changes
Mar 7, 2022
Codinablack
pushed a commit
to Codinablack/forgottenserver
that referenced
this pull request
Apr 5, 2022
(cherry picked from commit 1cef0ea)
EPuncker
pushed a commit
to EPuncker/forgottenserver
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Replaces custom
LuaVariantclass withstd::variantwith the same types. This reduces memory size of each instance from 56 bytes to 40 bytes, and allows for some code cleaning.Issues addressed:
Closes #1481