Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AUTHORS #3994

Merged
merged 6 commits into from
Mar 18, 2022
Merged

Update AUTHORS #3994

merged 6 commits into from
Mar 18, 2022

Conversation

EPuncker
Copy link
Contributor

@EPuncker EPuncker commented Mar 8, 2022

THIS PR WILL BE OPEN FOR A WEEK (WILL BE MERGED ON 15/03)

Everyone feel free to request changes or whatsoever

Pull Request Prelude

Changes Proposed

  • Updated to include everyone's name
  • Added OpenTibia developers
  • Removed emails

Sorry to anyone that was left out last time, it was not intentional and was made in a hurry, and for future reference, this is the one that is going to be used from now onwards:
git log --all --format='%aN' | sort -u | uniq > AUTHORS

Issues addressed:

@EPuncker EPuncker requested a review from marksamman March 8, 2022 11:48
Erza
Erza previously approved these changes Mar 8, 2022
AUTHORS Outdated Show resolved Hide resolved
@ranisalt
Copy link
Member

ranisalt commented Mar 9, 2022

Idea: maybe we could add that to the wiki instead of versioning it, then we can add a link in README

marksamman
marksamman previously approved these changes Mar 14, 2022
AUTHORS Outdated Show resolved Hide resolved
AUTHORS Outdated Show resolved Hide resolved
Co-authored-by: Ranieri Althoff <1993083+ranisalt@users.noreply.github.com>
EPuncker and others added 2 commits March 14, 2022 19:19
Co-authored-by: Ranieri Althoff <1993083+ranisalt@users.noreply.github.com>
@ranisalt
Copy link
Member

git log --all --format='%aN <%aE>' | sort -u | uniq > AUTHORS

This has changed, right? You're not exporting the emails anymore.

@EPuncker
Copy link
Contributor Author

git log --all --format='%aN <%aE>' | sort -u | uniq > AUTHORS

This has changed, right? You're not exporting the emails anymore.

yeah fixed the PR description, should be merged now

@EPuncker
Copy link
Contributor Author

@ranisalt accept&merge please

@EPuncker EPuncker merged commit 9ba9631 into otland:master Mar 18, 2022
@EPuncker EPuncker deleted the here-we-go-agane branch March 18, 2022 05:55
@ranisalt
Copy link
Member

@ranisalt accept&merge please

sorry I was sleeping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants