Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Npc:setSpeechBubble with param/bubble checks #4009

Merged
merged 1 commit into from
Mar 12, 2022
Merged

Improve Npc:setSpeechBubble with param/bubble checks #4009

merged 1 commit into from
Mar 12, 2022

Conversation

ramon-bernardo
Copy link
Contributor

@ramon-bernardo ramon-bernardo commented Mar 12, 2022 •
edited
Loading

Pull Request Prelude

Changes Proposed

  • Improve Npc:setSpeechBubble with param/bubble checks
  • Added SPEECHBUBBLE_LAST enum

@DSpeichert DSpeichert merged commit a5b4653 into otland:master Mar 12, 2022
@ramon-bernardo ramon-bernardo deleted the improve-npc-speechbubble branch March 13, 2022 00:02
@Zbizu Zbizu mentioned this pull request Apr 2, 2022
Closed
3 tasks
@ramon-bernardo ramon-bernardo mentioned this pull request Apr 4, 2022
Merged
3 tasks
EPuncker pushed a commit to EPuncker/forgottenserver that referenced this pull request May 23, 2023
@ramon-bernardo @EPuncker
Improve Npc:setSpeechBubble with param/bubble checks (otland#4009)
0017a51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MillhioreBT MillhioreBT MillhioreBT left review comments

@DSpeichert DSpeichert DSpeichert approved these changes

@EPuncker EPuncker EPuncker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ramon-bernardo @DSpeichert @EPuncker @MillhioreBT