Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enums: fixed conversion warning #4025

Merged
merged 5 commits into from
Mar 22, 2022
Merged

Conversation

DSpeichert
Copy link
Member

Pull Request Prelude

Changes Proposed

Issues addressed: Fixed conversion warning

@omarcopires
Copy link
Contributor

This resolves all warnings except tile.cpp(1124,30): warning C4245.

Copy link
Member

@ranisalt ranisalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, so good 👍 you can catch more of these issues by enabling -Wnarrowing -Wsign-compare (if on gcc or clang)

@EPuncker EPuncker merged commit 357bae1 into otland:master Mar 22, 2022
Codinablack pushed a commit to Codinablack/forgottenserver that referenced this pull request Apr 5, 2022
EPuncker pushed a commit to EPuncker/forgottenserver that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants