Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: text color in Windows cmd/powershell #4044

Merged
merged 1 commit into from
Mar 27, 2022
Merged

bugfix: text color in Windows cmd/powershell #4044

merged 1 commit into from
Mar 27, 2022

Conversation

Zbizu
Copy link
Contributor

@Zbizu Zbizu commented Mar 26, 2022

Pull Request Prelude

Steps to reproduce

(Windows 10)

  1. add a line like this one somewhere:
    fmt::print(fg(fmt::color::crimson) | fmt::emphasis::bold, "> ERROR: {:s}\n", errorStr);
  2. compile
  3. start by double clicking the server executable

observed and expected results can be seen on screenshots below

Changes Proposed

#3940 has introduced a colored message
colored messages sometimes fail to process in command prompt/powershell
this code fixes that issue (screenshots below)

NOTE: THESE SCREENSHOTS COME FROM MY FORK, THE LINE WHICH IS USED BY OFFICIAL TFS IS MENTIONED IN "STEPS TO REPRODUCE" SECTION

before:
NOTE: while this works properly in Visual Studio debugger, it breaks when you start the server normally
obraz

after:
obraz

Issues addressed: #3940 (merged PR)

#3940 introduced a colored message
colored messages sometimes fail to process in command prompt/powershell
this code fixes that issue
@DSpeichert DSpeichert merged commit 73bdc12 into otland:master Mar 27, 2022
@Zbizu Zbizu deleted the patch-1 branch March 27, 2022 21:50
Codinablack pushed a commit to Codinablack/forgottenserver that referenced this pull request Apr 5, 2022
otland#3940 introduced a colored message
colored messages sometimes fail to process in command prompt/powershell
this code fixes that issue

(cherry picked from commit 73bdc12)
EPuncker pushed a commit to EPuncker/forgottenserver that referenced this pull request May 23, 2023
otland#3940 introduced a colored message
colored messages sometimes fail to process in command prompt/powershell
this code fixes that issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants