bugfix: text color in Windows cmd/powershell #4044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Steps to reproduce
(Windows 10)
forgottenserver/src/otserv.cpp
Line 61 in 474b959
observed and expected results can be seen on screenshots below
Changes Proposed
#3940 has introduced a colored message
colored messages sometimes fail to process in command prompt/powershell
this code fixes that issue (screenshots below)
NOTE: THESE SCREENSHOTS COME FROM MY FORK, THE LINE WHICH IS USED BY OFFICIAL TFS IS MENTIONED IN "STEPS TO REPRODUCE" SECTION
before:
NOTE: while this works properly in Visual Studio debugger, it breaks when you start the server normally
after:
Issues addressed: #3940 (merged PR)