Fix addEvent scheduler values being passed by reference not value #4053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EPuncker
approved these changes
Mar 31, 2022
nekiro
changed the title
nekiro
changed the title
|
😡 |
Codinablack
pushed a commit
to Codinablack/forgottenserver
that referenced
this pull request
Apr 5, 2022
(cherry picked from commit bb41780)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4031
Apparently (from what I read on the internet) std::bind copies values, #4017 introduces usage of lambdas and this was changed to ref [&] and broke npcs and probably a lot more, so the solution is to bring back passing by value.