Removed MOTD

[EPuncker]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

GUILD MOTD HASN'T BEEN TOUTCHED!

For those who don't know what MOTD is, it was the small "Message Of The Day" window that appeared once a day before your character select window...

It was replaced in QT client by a new widget on client bottom, and it doesn't need any server-sided info:

I removed leftover code as it is not present in QT client anymore (since version 11?)

OTC can still be edited easily to have it client-sided only. https://github.com/edubart/otclient/blob/9c9b85ac5e9ae3cbacfc2d4993517c886d8881cd/modules/gamelib/protocollogin.lua#L186-L189

Issues addressed:
closes #4056

[Zbizu]

protocolstatus can return "N/A" string

[DSpeichert]

I'd leave the config option just to send it in XML and binary status protocol, at least while server lists use it.

[Zbizu]

I'd leave the config option just to send it in XML and binary status protocol, at least while server lists use it.

server lists are unlikely to back off considering that many servers are still running 8.6 and 10.98

[EPuncker]

re-review please 😄

[ranisalt]

LGTM

[Zbizu]

// MOTD

[EPuncker]

don't worry, @ranisalt clang will fix that in the future I hope

[DSpeichert]

I'd leave the config option just to send it in XML and binary status protocol, at least while server lists use it.

server lists are unlikely to back off considering that many servers are still running 8.6 and 10.98

That's why I think it's a feature to still be able to configure MOTD - as long as serverlists continue to show it, it's better to put something in there than just "N/A".

[EPuncker]

I'd leave the config option just to send it in XML and binary status protocol, at least while server lists use it.

server lists are unlikely to back off considering that many servers are still running 8.6 and 10.98

That's why I think it's a feature to still be able to configure MOTD - as long as serverlists continue to show it, it's better to put something in there than just "N/A".

nooo, it was a client feature, not otservlist feature, they can start to parse the new "MOTD" from server login.php now, it have lots of useful info: boosted creature id, players online, twitch viewers, event schedule etc

[LOLlolgrb]

It's still used by every single otlist, otclient is still using it. So why would it be removed?!? Jesus christ this repository has really fallen off the last couple of years...

Can we also update the readme to say that we're aiming to be a copy of tibia - not an open source mmorpg emulator and that you need to use the real tibia client to connect these days? That seems more accurate these days.

[EPuncker]

It's still used by every single otlist, otclient is still using it. So why would it be removed?!? Jesus christ this repository has really fallen off the last couple of years...

Can we also update the readme to say that we're aiming to be a copy of tibia - not an open source mmorpg emulator and that you need to use the real tibia client to connect these days? That seems more accurate these days.

if you are not happy, you can fork the repository and revert the patch, or not apply it to your current branch.

[LOLlolgrb]

It's still used by every single otlist, otclient is still using it. So why would it be removed?!? Jesus christ this repository has really fallen off the last couple of years...
Can we also update the readme to say that we're aiming to be a copy of tibia - not an open source mmorpg emulator and that you need to use the real tibia client to connect these days? That seems more accurate these days.

if you are not happy, you can fork the repository and revert the patch, or not apply it to your current branch.

If you don't want any users, keep your great work up.

The beauty with this PR is that we can finally see what servers are using TFS 1.5. Let me create a server list in a year that filters with this new dumb MOTD message, and let's see how many servers are actively using this distro, it won't be many.

[ranisalt]

@LOLlolgrb I am really eager to see your results, please ping me in the future.