Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved special doors registration to Lua #4100

Merged
merged 2 commits into from
May 3, 2022
Merged

Moved special doors registration to Lua #4100

merged 2 commits into from
May 3, 2022

Conversation

EPuncker
Copy link
Contributor

Pull Request Prelude

Changes Proposed

Moved special doors registration to Lua. Why? Take a look at how ugly and long it was in movements.xml

Now it is way easier to add a new door. And you can manage everything from a single place (global.lua)

Issues addressed:

ranisalt
ranisalt approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@ranisalt ranisalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not currently used, but probably useful to keep up to date)

Thy day hast finally cometh!

nekiro
nekiro approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@nekiro nekiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff

@EPuncker EPuncker merged commit da08851 into otland:master May 3, 2022
@EPuncker EPuncker deleted the doors-registering branch May 3, 2022 20:12
Codinablack pushed a commit to Codinablack/forgottenserver that referenced this pull request May 4, 2022
@EPuncker @Codinablack
Moved special doors registration to Lua (otland#4100)
9e27586 
(cherry picked from commit da08851)
EPuncker added a commit to EPuncker/forgottenserver that referenced this pull request May 23, 2023
@EPuncker
Moved special doors registration to Lua (otland#4100)
eda1444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranisalt ranisalt ranisalt approved these changes

@nekiro nekiro nekiro approved these changes

@DSpeichert DSpeichert Awaiting requested review from DSpeichert

@ramon-bernardo ramon-bernardo Awaiting requested review from ramon-bernardo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EPuncker @ranisalt @nekiro