Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit bool values instead of int in items.xml #4130

Merged
merged 3 commits into from
May 13, 2022
Merged

Use explicit bool values instead of int in items.xml #4130

merged 3 commits into from
May 13, 2022

Conversation

ramon-bernardo
Copy link
Contributor

Pull Request Prelude

Changes Proposed

  • int to explicit boolean valeus (1 to true, 0 to false)
  • remove default values (review necessary)

@EPuncker EPuncker merged commit 5ceea71 into otland:master May 13, 2022
@EPuncker EPuncker deleted the xml-bool branch May 13, 2022 00:03
EPuncker pushed a commit to EPuncker/forgottenserver that referenced this pull request May 23, 2023
@ramon-bernardo @EPuncker
Use explicit bool values instead of int in items.xml (otland#4130)
9f6bfa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EPuncker EPuncker EPuncker approved these changes

@nekiro nekiro Awaiting requested review from nekiro

@ranisalt ranisalt Awaiting requested review from ranisalt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ramon-bernardo @EPuncker