-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing monsters #4153
Add missing monsters #4153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- change all
<attack name="melee" interval="2000" skill="X" attack="X" />
to<attack name="melee" interval="2000" min="0" max="-VALUE" />
for a better/easier understanding of monster damage - change all spaces to tabs where needed
devourer_wave.lua
can be done entirely in xml just like a dragon wave with different area effectlisa_wave.lua
is just a regular wave as well- change
smokeue.lua
name to something more descriptive as it is not an ue(ultimate explosion) but a cross1x1 that reduces skill - change all
var
tovariant
renegade_knight.lua
is not being used anywhere
feel free to compare to this one, see if you missing any #3453 |
I will make a pull request to add these creatures you listed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data/spells/scripts/monster/infernalist_skill_reducer.lua
was added by mistake I suppose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only two more things
Co-authored-by: Evil Puncker <EPuncker@users.noreply.github.com>
Co-authored-by: Evil Puncker <EPuncker@users.noreply.github.com>
Co-authored-by: Evil Puncker <EPuncker@users.noreply.github.com>
Pull Request Prelude
Changes Proposed
Adds all missing monsters from the following updates:
10.90
10.80
10.70
10.50
8.54
8.5