Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing monsters #4153

Merged
merged 8 commits into from
Jun 10, 2022
Merged

Add missing monsters #4153

merged 8 commits into from
Jun 10, 2022

Conversation

omarcopires
Copy link
Contributor

Pull Request Prelude

Changes Proposed

Adds all missing monsters from the following updates:
10.90
10.80
10.70
10.50
8.54
8.5

Copy link
Contributor

@EPuncker EPuncker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • change all <attack name="melee" interval="2000" skill="X" attack="X" /> to <attack name="melee" interval="2000" min="0" max="-VALUE" /> for a better/easier understanding of monster damage
  • change all spaces to tabs where needed
  • devourer_wave.lua can be done entirely in xml just like a dragon wave with different area effect
  • lisa_wave.lua is just a regular wave as well
  • change smokeue.lua name to something more descriptive as it is not an ue(ultimate explosion) but a cross1x1 that reduces skill
  • change all var to variant
  • renegade_knight.lua is not being used anywhere

data/monster/monsters.xml Show resolved Hide resolved
data/monster/monsters/ekatrix.xml Outdated Show resolved Hide resolved
data/monster/monsters/enthralled_demon.xml Outdated Show resolved Hide resolved
data/monster/monsters/lisa.xml Outdated Show resolved Hide resolved
data/monster/monsters/lonely_polar_bear.xml Outdated Show resolved Hide resolved
data/monster/monsters/lonely_rotworm.xml Outdated Show resolved Hide resolved
data/monster/monsters/lonely_scorpion.xml Outdated Show resolved Hide resolved
data/monster/monsters/lonely_snake.xml Outdated Show resolved Hide resolved
data/monster/monsters/lonely_souleater.xml Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Jun 7, 2022

feel free to compare to this one, see if you missing any #3453

@omarcopires
Copy link
Contributor Author

feel free to compare to this one, see if you missing any #3453

I will make a pull request to add these creatures you listed.

Copy link
Contributor

@EPuncker EPuncker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data/spells/scripts/monster/infernalist_skill_reducer.lua

was added by mistake I suppose

@omarcopires omarcopires requested a review from EPuncker June 9, 2022 23:17
Copy link
Contributor

@EPuncker EPuncker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only two more things

omarcopires and others added 3 commits June 10, 2022 13:33
Co-authored-by: Evil Puncker <EPuncker@users.noreply.github.com>
Co-authored-by: Evil Puncker <EPuncker@users.noreply.github.com>
Co-authored-by: Evil Puncker <EPuncker@users.noreply.github.com>
@EPuncker EPuncker merged commit e1f9552 into otland:master Jun 10, 2022
@omarcopires omarcopires deleted the missing-monsters branch June 10, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants