Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to cancel LookDescription by returning an empty string #4176

Merged

Conversation

MillhioreBT
Copy link
Contributor

Pull Request Prelude

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Allow cancellation of the description message by returning an empty string.

Issues addressed: Nothing!

@ranisalt
Copy link
Member

What happens if you actually send an empty string, is that possible? I'm thinking maybe nil would be a better value for cancelling.

@MillhioreBT
Copy link
Contributor Author

What happens if you actually send an empty string, is that possible? I'm thinking maybe nil would be a better value for cancelling.

I also thought so although if we return nil we are not sure that a next event will not treat this parameter as a string and it would break backwards compatibility, certain scripts might throw errors that you are treating nil as a string
This is because the parameters are auto-updated on each iteration of each registered eventcallback.

@EPuncker EPuncker merged commit 478f0e6 into otland:master Aug 10, 2022
EPuncker pushed a commit to EPuncker/forgottenserver that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants