Fixed argument order on luaDoAreaCombat #4212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
EPuncker
requested review from
DSpeichert,
nekiro,
ramon-bernardo and
ranisalt
|
If nobody noticed that before, is anyone even using this function? Can we move it to compat and use a |
|
ramon-bernardo
approved these changes
Sep 24, 2022
| params.blockedByArmor = getBoolean(L, 8, false); | ||
| params.blockedByShield = getBoolean(L, 9, false); | ||
| params.ignoreResistances = getBoolean(L, 10, false); | ||
|
|
There was a problem hiding this comment.
Suggested change
| // CombatOrigin origin = getNumber<CombatOrigin>(L, 8, ORIGIN_SPELL); |
EPuncker
added a commit
to EPuncker/forgottenserver
that referenced
this pull request
May 23, 2023
Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Zbizu Zbizu@users.noreply.github.com
Pull Request Prelude
Changes Proposed
Fixed argument order from doAreaCombat script command:
doAreaCombat(cid = 1, type = 2, pos = 3, area = 4, min = 5, max = 6, effect = 7, origin = 8, blockArmor = 9, blockShield = 10, ignoreResistances = 11)as you can check above,
blockedByArmor,minandmaxwere wrong