Refresh speed on vocation change. #4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, after changing vocation tfs will refresh baseSpeed only after login/leveling up/losing a level. It shouldn't work like that, it should refresh baseSpeed directly on changing vocation to an another one.
EPuncker
approved these changes
Sep 22, 2022
EPuncker
requested review from
nekiro,
ranisalt,
DSpeichert and
ramon-bernardo
|
since vocation speed can be changed, this makes sense |
MillhioreBT
approved these changes
Sep 23, 2022
danyelvarejao
approved these changes
Sep 23, 2022
EPuncker
pushed a commit
to EPuncker/forgottenserver
that referenced
this pull request
May 23, 2023
By default, after changing vocation tfs will refresh baseSpeed only after login/leveling up/losing a level. It shouldn't work like that, it should refresh baseSpeed directly on changing vocation to an another one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
By default, after changing vocation tfs will refresh baseSpeed only after login/leveling up/losing a level. It shouldn't work like that, it should refresh baseSpeed directly on changing vocation to an another one.
Example:
vocation 1 has baseSpeed = 250
vocation 2 has baseSpeed = 300
Then you have code: player:setVocation(2)
You will still have 250 baseSpeed until you do one of the following:
Adding those 3 lines that I suggested to add will make it refresh baseSpeed instantly.
Issues addressed: