Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change vocation map to unordered_set and improve weapons.cpp code format #4226

Merged
merged 8 commits into from
Oct 30, 2022
Merged

Change vocation map to unordered_set and improve weapons.cpp code format #4226

merged 8 commits into from
Oct 30, 2022

Conversation

ramon-bernardo
Copy link
Contributor

Pull Request Prelude

Changes Proposed

  • Improve code format

@EPuncker EPuncker added the enhancement Increase or improvement in quality, value, or extent label Oct 17, 2022
EPuncker
EPuncker previously approved these changes Oct 17, 2022
View reviewed changes
ranisalt
ranisalt requested changes Oct 17, 2022
View reviewed changes
src/weapons.cpp Show resolved Hide resolved
src/weapons.cpp Outdated Show resolved Hide resolved
@ramon-bernardo ramon-bernardo changed the title Improve weapons.cpp code format Change vocation map to unordered_set and improve weapons.cpp code format Oct 18, 2022
ramon-bernardo
ramon-bernardo commented Oct 18, 2022
View reviewed changes
src/spells.cpp Outdated Show resolved Hide resolved
ranisalt
ranisalt reviewed Oct 19, 2022
View reviewed changes
src/movement.h Outdated Show resolved Hide resolved
ranisalt
ranisalt requested changes Oct 19, 2022
View reviewed changes
Copy link
Member

@ranisalt ranisalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some avoidable copies

src/movement.h Outdated Show resolved Hide resolved
src/spells.h Outdated Show resolved Hide resolved
src/weapons.h Outdated Show resolved Hide resolved
ranisalt
ranisalt reviewed Oct 21, 2022
View reviewed changes
src/spells.h Show resolved Hide resolved
ranisalt
ranisalt approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@ranisalt ranisalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramon-bernardo ramon-bernardo merged commit 07c2763 into master Oct 30, 2022
@ramon-bernardo ramon-bernardo deleted the code-format branch October 30, 2022 21:55
MillhioreBT added a commit to Unreal-TFS/forgottenserver that referenced this pull request Dec 11, 2022
@MillhioreBT
weapon problems introduced in otland#4226 fixed.
071eed3
@MillhioreBT MillhioreBT mentioned this pull request Dec 11, 2022
Merged
3 tasks
@xmish xmish mentioned this pull request Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranisalt ranisalt ranisalt approved these changes

@EPuncker EPuncker EPuncker approved these changes

@DSpeichert DSpeichert Awaiting requested review from DSpeichert

@nekiro nekiro Awaiting requested review from nekiro

Assignees
No one assigned
Labels
enhancement Increase or improvement in quality, value, or extent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ramon-bernardo @ranisalt @EPuncker