Reverting PR

[tornadia]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Fixes #4263
Reverts https://github.com/otland/forgottenserver/pull/3495/files

Issues addressed: 4263

[EPuncker]

@danyelvarejao can you check this please

[ranisalt]

Summary of changes:

Before: if either force load or reloading AND the monster is not loaded, then load. That means that if the monster was already loaded, then forceLoad has no effect.

After: forceLoad is enough to load the monster, even if it was already loaded. Read it as if (forceLoad || (reloading && monsters.find(it.first) != monsters.end())) {

[danyelvarejao]

I think it should be like @ranisalt said.

if (forceLoad || (reloading && monsters.find(it.first) != monsters.end())) {

[tornadia]

I think it should be like @ranisalt said.

if (forceLoad || (reloading && monsters.find(it.first) != monsters.end())) {

It literally makes no difference to wrap that statement around parentheses as that is what the order of operators is already doing, i.e. BEDMAS/PEDMAS in math, AND (&&) operators have precedence over OR (||)

[ranisalt]

For reference: https://en.cppreference.com/w/cpp/language/operator_precedence

It would be good to wrap for clarity, it's not that obvious

[ranisalt]

To whoever merges this, please add a proper commit message

[EPuncker]

To whoever merges this, please add a proper commit message

I love chatGTP