Random item: Unrealized Dream #4272

omarcopires · 2022-12-14T20:21:38Z

I have followed proper The Forgotten Server code styling.
I have read and understood the contribution guidelines before making this PR.
I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Add a missing random item

Co-Authored-By: Evil Puncker <EPuncker@users.noreply.github.com>

Co-Authored-By: torresmon <70948057+torresmon@users.noreply.github.com>

ranisalt · 2022-12-22T22:29:33Z

Checking chanceFrom is not useful if it will always equal changeTo from the previous item, if chance <= randomItem.chanceTo then is enough

Random item: Unrealized Dream

3e051be

omarcopires closed this Dec 14, 2022

omarcopires deleted the random-item branch December 14, 2022 22:26

omarcopires restored the random-item branch December 18, 2022 03:26

omarcopires reopened this Dec 18, 2022

omarcopires and others added 3 commits December 18, 2022 00:27

Update unrealized_dream.lua

7b9a546

Update unrealized_dream.lua

6ee525e

Co-Authored-By: Evil Puncker <EPuncker@users.noreply.github.com>

Update unrealized_dream.lua

fb580b0

Co-Authored-By: torresmon <70948057+torresmon@users.noreply.github.com>

EPuncker requested review from DSpeichert and ranisalt December 18, 2022 11:33

EPuncker approved these changes Dec 18, 2022

View reviewed changes

EPuncker merged commit c70a64a into otland:master Dec 22, 2022

omarcopires deleted the random-item branch December 22, 2022 20:15

Provide feedback