Fix: Price of NPC's items #4293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
DSpeichert
reviewed
Jan 19, 2023
EPuncker
approved these changes
Jan 27, 2023
Kamenuvol
reviewed
Jan 29, 2023
| @@ -960,7 +960,7 @@ if not Modules then | |||
| return false | |||
| end | |||
|
|
|||
| if shopItem.buy == -1 then | |||
| if shopItem.buy == 0 then | |||
There was a problem hiding this comment.
I think it should be a valid value to buy/sell for free. To not be buyable/sellable the value in Lua table should be nil.
There was a problem hiding this comment.
I don't think the client can handle that (haven't tested), since cip sell items for 1 gp at testserver assistant and not 0 (for free)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Fixes the window for buying and selling items on NPC's.
Credits: @Zbizu
Issues addressed:
Closes #4292