Improve monsters turning to target behaviour

[marmichalski]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

• Simplify updateLookDirection logic removing 2-step turning in some cases.
• Update look direction on successful attack or when melee was out of reach

There is still some room for improvement when it comes to ranged creatures more than necessarily turning to you while they're running to keep distance. I may or may not fix it in separate PR, as this is another issue.

@emil92b pls test

Issues addressed: #4255

[emil92b]

seem to work for melee, not sure about ranged, also noticed in real tibia they move more frequently, but thats another issue too. btw you don't need to rename and bool flip

[marmichalski]

btw you don't need to rename and bool flip

Without flipping the bool they would still be turning twice most of the times, as this method is fired more often than the actual attack. And it seemed like they turn on attack in vanilla. 🙈

[emil92b]

btw you don't need to rename and bool flip

Without flipping the bool they would still be turning twice most of the times, as this method is fired more often than the actual attack. And it seemed like they turn on attack in vanilla. 🙈

isn't it same logic tho, only difference is this lastMeleeAttack == 0 which i assume takes care of the double turning

[marmichalski]

btw you don't need to rename and bool flip

Without flipping the bool they would still be turning twice most of the times, as this method is fired more often than the actual attack. And it seemed like they turn on attack in vanilla. 🙈

isn't it same logic tho, only difference is this lastMeleeAttack == 0 which i assume takes care of the double turning

Nope. With true as default the creature would turn anytime this method is called, which IIRC was through game.checkCreatures. lastMeleeAttack == 0 is for ranged/non-hostile creatures to face you - this means the target was out of range for melee, or the creature has no melee at all (and also that it's the first ever melee attack of this monster, but thats of no importance).

Edit: Hold on. I'm a little bit slower today. Yes, not flipping the bool and leaving the && would actually work the same. Thought rename + flip makes it a little bit more explicit.

[ranisalt]

I prefer the new name nevertheless. lookUpdated is clear, it has been updated, while updateLook to me means that it should be updated, which is not the case