Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid argument in spell:group #4305

Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix invalid argument in spell:group #4305

merged 1 commit into from
Jan 30, 2023

Conversation

Zbizu
Copy link
Contributor

@Zbizu Zbizu commented Jan 29, 2023

Steps to reproduce

  1. set two groups to Lua spell, for example spell:group(1, 2)
  2. set two cooldowns like spell:groupCooldown(2000, 22000)
  3. observe cooldowns bar

expected: two groups have cooldowns
observed: secondary group is ignored despite the function arguments suggesting otherwise

Copy link
Contributor

@EPuncker EPuncker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@EPuncker EPuncker merged commit 3a180d8 into otland:master Jan 30, 2023
@Zbizu Zbizu deleted the patch-9 branch January 31, 2023 01:36
EPuncker pushed a commit to EPuncker/forgottenserver that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants