Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player.isPromoted() #4324

Merged
merged 2 commits into from
Feb 18, 2023
Merged

Player.isPromoted() #4324

merged 2 commits into from
Feb 18, 2023

Conversation

xmish
Copy link
Contributor

@xmish xmish commented Feb 17, 2023

Function to check whether player has promotion (some level of promotion) Simple comapre:

  • vocation attribute "fromvoc" == vocation.id
  • no net to compare with "base" vocation as it's only to check if player has some promotion (any level)

Works for any amount of "base" vocations

Pull Request Prelude

Changes Proposed

Issues addressed:

xmish and others added 2 commits February 17, 2023 19:05
Function to check whether player has promotion (some level of promotion)
Simple comapre:
- vocation attribute "fromvoc" == vocation.id
- no net to compare with "base" vocation as it's only to check if player has some promotion (any level)

Works for any amount of "base" vocations
@xmish xmish marked this pull request as ready for review February 17, 2023 18:12
@xmish xmish changed the title Update player.lua Player.isPromoted() Feb 17, 2023
@EPuncker EPuncker merged commit 6307298 into otland:master Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants