Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid extra copy in PropStream::readString() #4341

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Avoid extra copy in PropStream::readString() #4341

merged 1 commit into from
Mar 7, 2023

Conversation

ranisalt
Copy link
Member

@ranisalt ranisalt commented Mar 6, 2023

Pull Request Prelude

Changes Proposed

Avoids an unnecessary copy in PropStream::readString()

@EPuncker EPuncker merged commit dccc3bc into otland:master Mar 7, 2023
@ranisalt ranisalt deleted the avoid-copy-readstring branch March 8, 2023 00:35
EPuncker pushed a commit to EPuncker/forgottenserver that referenced this pull request May 23, 2023
@ranisalt @EPuncker
Avoid extra copy in PropStream::readString() (otland#4341)
702fe39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EPuncker EPuncker EPuncker approved these changes

@nekiro nekiro nekiro approved these changes

@MillhioreBT MillhioreBT MillhioreBT approved these changes

@DSpeichert DSpeichert Awaiting requested review from DSpeichert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ranisalt @EPuncker @nekiro @MillhioreBT