Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes some spell bugs #4354

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Fixes some spell bugs #4354

merged 1 commit into from
Mar 25, 2023

Conversation

omarcopires
Copy link
Contributor

Pull Request Prelude

Changes Proposed

  • Changes names from Practice to Practise
  • Changes setCombatCallback(combat, CALLBACK_PARAM_TARGETTILE, "onTargetTile") to combat:setCallback(CALLBACK_PARAM_TARGETTILE, "onTargetTile")

@omarcopires omarcopires marked this pull request as draft March 24, 2023 22:03
Zbizu
Zbizu approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@Zbizu Zbizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far so good

@omarcopires omarcopires marked this pull request as ready for review March 24, 2023 22:56
@EPuncker EPuncker merged commit ca4e8a2 into otland:master Mar 25, 2023
@omarcopires omarcopires deleted the fix-spells branch March 25, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EPuncker EPuncker EPuncker approved these changes

@Zbizu Zbizu Zbizu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@omarcopires @EPuncker @Zbizu