Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMake presets and vcpkg manifest in workflows #4376

Merged
merged 17 commits into from
Apr 9, 2023

Conversation

ranisalt
Copy link
Member

@ranisalt ranisalt commented Apr 5, 2023

Pull Request Prelude

Changes Proposed

Issues addressed: fixes the current build error for Windows builds

@ArturKnopik
Copy link
Contributor

WOW, it's working for windows :D

@ranisalt
Copy link
Member Author

ranisalt commented Apr 6, 2023

WOW, it's working for windows :D

It's not doing anything 😂 I would be surprised if it didn't work

@ranisalt
Copy link
Member Author

ranisalt commented Apr 8, 2023

I removed FindPugiXML.cmake because it is shipped by default on Ubuntu, Arch Linux, vcpkg and a few more widely used distros, with a much better script for it. No point in keeping it, and I'll do the same with other modules that are unnecessary.

@ArturKnopik
Copy link
Contributor

Will be nice to fix builds asap... windows build is broken again...

@ranisalt ranisalt marked this pull request as ready for review April 8, 2023 20:15
Copy link
Member

@DSpeichert DSpeichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@DSpeichert DSpeichert merged commit 94bf436 into otland:master Apr 9, 2023
@ranisalt ranisalt deleted the fix-windows-build branch April 9, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants