Quest moved to lua (Part 2)

[MillhioreBT]

Pull Request Prelude

• I have followed [proper The Forgotten Server code styling][code].
• I have read and understood the [contribution guidelines][cont] before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

This is the new version of PR #4261, everything is neater and more consistent with namespaces as you suggested @ranisalt

The tracker now updates if the value is -1

Issues addressed: Nothing!

[dex-89]

I have only one question, what is the purpose of transferring quests and other elements from the engine to lua?

[MillhioreBT]

I have only one question, what is the purpose of transferring quests and other elements from the engine to lua?

The reason for moving this to lua are several:

• Quests in lua are versatile, you can create your own quests based on your own criteria and not just storages.
• Being in lua we are freeing load on sources, you don't need the wonderful low level power of C++ for this nonsense.
• The packet event manager in lua needs work and here we are giving you one.
• Everything that can be handled in lua should be in lua and not in the sources.
• Etc...

If you are concerned about compatibility, the PR is compatible with xml.

[Zbizu]

setting storage value to -1 does not update the quest in tracker (actually the quest tracker is often ignoring status update when storage values are out of scope)

steps to reproduce:

• configure mission as start value -1, end value 10
• set value to -1 (player:setStorageValue(key, value))
• set value to -2
• set value to 0 (observed: when oldValue is out of scope, but newValue is within scope, tracker update is not sent)
• set value to anything within scope (updates properly)
• set value to anything out of scope (updates properly)
• set value to anything within scope (does not update)
• set value to anything within scope again (updates properly)

also sry for not reviewing everything at once, I caught a cold and I'm taking breaks frequently

[omarcopires]

I believe xml compatibility should not be enabled by default and the quests.xml file should be removed.

[Zbizu]

looks good so far (local tests)
If you wait one week, I can post results from production also.

[omarcopires]

A warning is being printed to the console when starting the server:
[Warning - Events::load] Unknown player method: onUpdateStorage

You forgot to add below code in events.cpp:

} else if (methodName == "onUpdateStorage") {
	info.playerOnUpdateStorage = event;

I didn't find any other problems besides that.

[Zbizu]

I've ran it successfully on production for 2 days and haven't had any error reports or server issues related to it.