-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bestiary in Lua #4402
Bestiary in Lua #4402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add an example for xml entry too
After killing some Dragon Lords using
|
Oops sorry, I forgot not all elements are counted here, I'll fix this in a bit, thanks for reminding me <3 |
Okay, no errors were returned in any of the bestiary steps and no crash occurred to me. However I encountered a problem when killing a monster in a party:
|
On the client side everything is as it should, I believe it can be merged as it is. If there is no change suggested by any staff member. Thanks Arthur and Sarah for the content. |
The points will no longer be counted twice for those who inflict damage to the monsters and are in the same group. |
Pull Request Prelude
Changes Proposed
These changes are inspired by the PR linked as Based.
Basically, this PR adds the possibility of partially enabling the bestiary system, more information needs to be added, but this is a good starting point.
The
MonsterType
function now also accepts a raceId to obtain the MonsterType linked to that raceId.New function
Game.getBestiary()
that returns a table with other tables containing name and list of MonsterTypes, both compatible with the Lua#
operator.Compatible with Revscript.
Based: #4356