Update lua-syntax action to latest version #4437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranisalt
reviewed
May 1, 2023
Co-authored-by: Ranieri Althoff <1993083+ranisalt@users.noreply.github.com>
kornholi
reviewed
May 2, 2023
| with: | ||
| luaVersion: "5.3.5" | ||
| luaVersion: "5.4" |
There was a problem hiding this comment.
LuaJIT barely supports any 5.2 and 5.3 features. I wonder if we should test with 5.1 instead.
There was a problem hiding this comment.
Or get rid of LuaJIT and go full Lua 5.4. LuaJIT at this point is a single-maintainer project with no releases for the past 6 years. It's not like we're doing scientific computing or other CPU-heavy workloads that would benefit from it, Lua 5.4 is good enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Update lua-syntax action to latest version, Action now runs on node16 as node 12 actions are marked as deprecated:
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
also bumped Lua version from 5.3.5 to 5.4 (it will default to latest 5.4.* version)
Issues addressed: