Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created lua-check.yml file #4440

Merged
merged 2 commits into from
May 4, 2023

Conversation

shabbir23ah
Copy link
Contributor

@shabbir23ah shabbir23ah commented May 2, 2023

GitHub action .yml file for Lua code formatting and linting according issue #4433

Pull Request Prelude

Changes Proposed

Add Luacheck github action #4433

Issues addressed:

GitHub action .yml file for Lua code formatting and linting according issue  otland#4433
.github/workflows/lua-check.yml Outdated Show resolved Hide resolved
.github/workflows/lua-check.yml Outdated Show resolved Hide resolved
.github/workflows/lua-check.yml Outdated Show resolved Hide resolved
.github/workflows/lua-check.yml Outdated Show resolved Hide resolved
@ranisalt
Copy link
Member

ranisalt commented May 2, 2023

A few suggestions:

  • Please add these jobs to the workflow in .github/workflows/lua-syntax.yml so that related checks are on the same description
  • Use the latest version of Lua and the action (just like in the same file)
  • I think renaming it to lua-check.yml would be good!

@shabbir23ah
Copy link
Contributor Author

My apologies, allow me to clarify my intentions
I will combine lua-check.yml jobs into lua-syntex.yml to keep all jobs in single file and rename the file's name to lua-check.yml, right?

@ranisalt
Copy link
Member

ranisalt commented May 3, 2023

I will combine lua-check.yml jobs into lua-syntex.yml to keep all jobs in single file and rename the file's name to lua-check.yml, right?

Yes, precisely

I have consolidate all jobs from `lua-check.yml` file into `lua-syntax.yml` and renamed to "lua-check.yml". Also upated lua & action version
@shabbir23ah
Copy link
Contributor Author

consolidate all jobs into single file lua-check.yml and updated version

@EPuncker EPuncker linked an issue May 4, 2023 that may be closed by this pull request
@kornholi kornholi merged commit 98d06e4 into otland:master May 4, 2023
@shabbir23ah shabbir23ah deleted the luacheck-github-action branch May 5, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Luacheck github action
6 participants