notify the client about NPC speechbubble update #4464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EPuncker
approved these changes
May 27, 2023
ranisalt
approved these changes
May 29, 2023
| @@ -4971,6 +4971,17 @@ void Game::updateCreatureWalkthrough(const Creature* creature) | |||
| } | |||
| } | |||
|
|
|||
| void Game::updateKnownCreature(const Creature* creature) | |||
There was a problem hiding this comment.
This sounds a bit misleading, as it is not a known creature, this just sends an update of a creature to spectators. Known creatures are cached and may not be in spectator-range of a player. See the comment I've left in Monster::setName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Follow-up of PR #4058
Issues addressed: #4463