Fix Memory Leak from Npc events #4483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: yamaken93 <1008865+yamaken93@users.noreply.github.com>
MillhioreBT
requested review from
yamaken93,
DSpeichert,
ranisalt,
EPuncker and
nekiro
|
I would advocate for making NpcEventsHandler per npc and not global for all npcs (also wrap it in unique_ptr to avoid destructor), for some odd reason its global for npcs and the memory usage changes are marginal |
Co-Authored-By: yamaken93 <1008865+yamaken93@users.noreply.github.com>
nekiro
previously approved these changes
Jun 8, 2023
ranisalt
reviewed
Jun 9, 2023
ranisalt
reviewed
Jun 9, 2023
ranisalt
reviewed
Jun 10, 2023
ranisalt
reviewed
Jun 10, 2023
EPuncker
added
enhancement
ranisalt
approved these changes
Jun 22, 2023
2 tasks
ralke23
added a commit
to ralke23/Greed-TFS-1.5-Downgrades
that referenced
this pull request
Apr 22, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
These changes remove the global lua interface for all npc, and now each npc has its own lua interface, in turn the handler and interface become smart pointers so that their removal is handled automatically
Here is a visual example of a graph showing how memory usage changes when creating and deleting 5000 Npcs, and then the garbage collector cleaning up everything.
Issues addressed: #4288