New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix Database double init (#4482)" #4484

Merged

nekiro merged 1 commit into otland:master from ArturKnopik:revertDataBaseChanges

Jun 9, 2023

Contributor

ArturKnopik commented Jun 9, 2023

This reverts commit 56d1bc8.

After discussion with @nekiro i decided to revert DB changes. There is high risk to block main thread when query takes to much time.

Pull Request Prelude

I have followed [proper The Forgotten Server code styling][code].
I have read and understood the [contribution guidelines][cont] before making this PR.
I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.


          Revert "fix Database double init (otland#4482)"

e75960e

This reverts commit 56d1bc8.

nekiro approved these changes

View reviewed changes

nekiro merged commit 2e0a4df into otland:master

6 of 18 checks passed

ArturKnopik deleted the revertDataBaseChanges branch

June 9, 2023 13:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment