-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creature/Monster Icons #4493
Merged
Merged
Creature/Monster Icons #4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: KrecikOnDexin <krecikondexin@gmail.com> Co-Authored-By: Zbizu <Zbizu@users.noreply.github.com>
EPuncker
previously approved these changes
Jun 26, 2023
ranisalt
reviewed
Jun 26, 2023
EPuncker
previously approved these changes
Jun 28, 2023
EPuncker
previously approved these changes
Apr 17, 2024
EvilHero90
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now
EPuncker
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
These changes add the possibility of adding the new icons for creatures/monsters.
![image](https://private-user-images.githubusercontent.com/28090948/248593248-21531ceb-224d-490f-af8d-3234c276cb3e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkzMzU1NDgsIm5iZiI6MTcxOTMzNTI0OCwicGF0aCI6Ii8yODA5MDk0OC8yNDg1OTMyNDgtMjE1MzFjZWItMjI0ZC00OTBmLWFmOGQtMzIzNGMyNzZjYjNlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI1VDE3MDcyOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUzYTBhOWRjOGVkZGE0OWZhNjc2Mzc4MmMwZTJkNjBkODMxZTBhZjhmOGE0M2NjNDlkNDVlMjRhMzA1ZDMxMDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.QR4mEmdvlfQg6qjqQY3qW7QMXLygcQ4227gOpWlOUrY)
They are very important for the new mechanics and systems.
There was already a PR proposing this, but the person maintaining it seems to be AFK, so I wanted to save some time.
Issues addressed: Nothing!