Separate onGainExperience logic into its own file #4505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MillhioreBT
added
the
priority: low
omarcopires
reviewed
Jul 19, 2023
data/scripts/eventcallbacks/player/default_onGainExperience.lua
Outdated
Show resolved
Hide resolved
omarcopires
approved these changes
Jul 19, 2023
EPuncker
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
These changes add a new eventcallback file for the default onGainExperience event, where the logic is worked on separately. Additionally, an event is added for the message, which is also separated and uses the positive infinite activation index to ensure that this event is activated at the end of all events. This guarantees that it is the last event and therefore any changes to the experience made in the previous events are taken into account.
Issues addressed: Nothing!