Use Ninja multi-config with CMake #4517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranisalt
force-pushed
the
ninja-multi-config
branch
from
3acc486
to
1a51587
Compare
EPuncker
previously approved these changes
Oct 1, 2023
ranisalt
force-pushed
the
ninja-multi-config
branch
2 times, most recently
from
ce40df0
to
c955586
Compare
ranisalt
force-pushed
the
ninja-multi-config
branch
from
c955586
to
3e80bdc
Compare
EPuncker
previously approved these changes
Dec 10, 2023
EPuncker
previously approved these changes
Dec 13, 2023
ranisalt
force-pushed
the
ninja-multi-config
branch
from
db7851c
to
0335b19
Compare
EPuncker
previously approved these changes
Apr 27, 2024
- Setup tests dependency install with vcpkg - Fix preset additional args for run-cmake action
ranisalt
force-pushed
the
ninja-multi-config
branch
from
0335b19
to
686a993
Compare
EPuncker
approved these changes
Apr 29, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Issues addressed:
Using Ninja multi-config allows us to build in multiple configurations, such as Debug, RelWithDebInfo and Release.
Currently, one needs to pass the build type prior to generating makefiles, with
cmake --preset default -DCMAKE_BUILD_TYPE=<buildtype>followed bycmake --build --preset default, and rebuilding with a different config required regenerating makefiles.Now, a clearer invocation of
cmakeis possible withcmake --preset defaultto generate makefiles, and thencmake --build --preset default --config <buildtype>is possible without regenerating makefiles, and in separate folders so that one can maintain multiple builds (for debugging and running in production, for example)