Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal Window Helper] Return botton / choice #4529

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

MillhioreBT
Copy link
Contributor

Pull Request Prelude

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

By returning the button or choice then we can add new fields that can be used for anything.

Example:

local button = modalWindow:addButton(...)
button.value = index
local choice = modalWindow:addChoice(...)
choice.parameter = index

I have also added (line breaks) \n in io.write messages, since io.write doesn't add newlines at the end.

Issues addressed: Nothing!

@MillhioreBT MillhioreBT merged commit 9dc86d0 into otland:master Sep 5, 2023
4 checks passed
@MillhioreBT MillhioreBT deleted the modalwindowhelper_details branch September 5, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants