Improve IO ban information #4544

ramon-bernardo · 2023-09-30T04:32:07Z

I have followed proper The Forgotten Server code styling.
I have read and understood the contribution guidelines before making this PR.
I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

src/ban.cpp

Improve IO ban information

922947f

EPuncker requested review from DSpeichert, ranisalt, nekiro and MillhioreBT September 30, 2023 04:33

EPuncker added the enhancement Increase or improvement in quality, value, or extent label Sep 30, 2023

const ptrs

83e4beb

EPuncker previously approved these changes Sep 30, 2023

View reviewed changes

ramon-bernardo dismissed EPuncker’s stale review via 83e4beb September 30, 2023 04:34

ramon-bernardo added 2 commits September 30, 2023 01:42

const ref ptr

6e7fe5d

clang format grr!

6f0be97

ranisalt reviewed Sep 30, 2023

View reviewed changes

src/ban.cpp Outdated Show resolved Hide resolved

Use optional instead shared ptr

fee4f9f

EPuncker requested a review from ranisalt September 30, 2023 17:52

MillhioreBT requested changes Oct 5, 2023

View reviewed changes

src/ban.cpp Outdated Show resolved Hide resolved

ramon-bernardo added 2 commits October 8, 2023 13:17

Fix method name

03c24bc

Use getBanInfo

286369f

EPuncker approved these changes Oct 13, 2023

View reviewed changes

EPuncker requested a review from MillhioreBT October 13, 2023 19:53

EPuncker approved these changes Dec 13, 2023

View reviewed changes

MillhioreBT approved these changes Dec 13, 2023

View reviewed changes

EPuncker merged commit ffba1d8 into otland:master Dec 13, 2023
19 checks passed

ramon-bernardo deleted the ioban-info branch December 13, 2023 00:37

Provide feedback