Fix normal_random behavior on negative parameters #4555
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
When the algorithm was updated to avoid skew #4539 I accidentally broke passing negative numbers in reverse order (e.g. calling
normal_random(-1, -100)
instead ofnormal_random(-100, -1)
) due to the waystd::minmax
works: it returns references to the minimum and maximum element, and combined withstd::tie
it would replaceminNumber
in-place before it's value was moved tomaxNumber
.Storing the values in local variables fixes the problem without adding an explicit branch + swap as proposed in the comments.
Issues addressed: fixes #4554