fix: update client on advance #4604
Conversation
| @@ -0,0 +1,17 @@ | |||
| local updateClientOnAdvance = CreatureEvent("Update Client On Advance") | |||
There was a problem hiding this comment.
I would remove this file completely
There was a problem hiding this comment.
Also the new file name and title have less semantic
There was a problem hiding this comment.
the script does exactly what the name says and now works as it should, there is no point in changing it.
There was a problem hiding this comment.
Not at all. And please do not resolve my conversation if there is an open discussion.
There was a problem hiding this comment.
If you're not satisfied with my approach, make a request yourself and let the moderators decide.
You are being very annoying to someone who never or almost never contributes anything.
There was a problem hiding this comment.
| @@ -0,0 +1,17 @@ | |||
| local updateClientOnAdvance = CreatureEvent("Update Client On Advance") | |||
|
|
|||
| function updateClientOnAdvance.onAdvance(player, skill, oldLevel, newLevel) | |||
There was a problem hiding this comment.
Not at all. This script is not doing "exactly what the name say" because then the script should be named "update_client_exp_display_on_level_change_and_take_screenshot_on_any_skill_change.lua"
There was a problem hiding this comment.
IMO, no reason to remove the other two files.
There was a problem hiding this comment.
This new script has less semantic and more responsibilities.
There was a problem hiding this comment.
And please, do not resolve my comments if there is an ongoing discussion.
| @@ -6,7 +6,10 @@ function updateClientOnAdvanceLevel.onAdvance(player, skill, oldLevel, newLevel) | |||
| end | |||
|
|
|||
| player:updateClientExpDisplay() | |||
| player:takeScreenshot(SCREENSHOT_TYPE_LEVELUP) | |||
|
|
|||
| if newLevel > oldLevel then | |||
| @@ -1,7 +1,7 @@ | |||
| local updateClientOnAdvanceSkill = CreatureEvent("Update Client On Advance Skill") | |||
|
|
|||
| function updateClientOnAdvanceSkill.onAdvance(player, skill, oldLevel, newLevel) | |||
| if skill == SKILL_LEVEL then | |||
| if skill == SKILL_LEVEL and newLevel > oldLevel then | |||
There was a problem hiding this comment.
Though, why the and newLevel > oldLevel here? This script will now take a screenshot if the player losses a level.
Pull Request Prelude
Changes Proposed
Now, the screenshot (takeScreenshot) is only triggered if the new level is greater than the old level.
Issues addressed:
The client takes a screenshot even when the player loses level.